fix: move request body models to module level to fix 422 on POST#83
Merged
Conversation
With , inline BaseModel classes defined inside create_app() cause FastAPI/Pydantic to treat body params as query params, returning a silent 422 validation error on every exec/read/write POST. Moving _ExecRequest, _ReadRequest, and _WriteRequest to module level resolves the annotation resolution issue. Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
Go client's ReadResultPayload and WritePayload use content_b64 (base64-encoded) for file content, but the Python plugin was using raw content with the wrong field name: - tools.py _node_read_impl: read 'content' instead of 'content_b64' from Go's read_result response. Added base64 decode. - server.py nodes_write: sent 'content' instead of 'content_b64' to the Go client. Now base64-encodes before sending. Fixes node_read returning empty content and node_write returning bytes_written=0 on macOS (and any platform). Signed-off-by: Blasius Patrick <blasius.patrick@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With , inline BaseModel classes
defined inside create_app() cause FastAPI/Pydantic to treat body params as query params, returning a silent 422 validation error on every exec/read/write POST.
Moving _ExecRequest, _ReadRequest, and _WriteRequest to module level resolves the annotation resolution issue.